Skip to content

Conversation

@chrisronline
Copy link
Contributor

Resolves #51523
Resolves #51477
Resolves #51483

Testing isn't straight-forward. The best choice is to checkout 7.5, cherry-pick this commit, then run the functional tests against cloud

@chrisronline chrisronline self-assigned this Nov 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chrisronline
Copy link
Contributor Author

cc @liza-mae

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty fly 😎

@chrisronline
Copy link
Contributor Author

I'm going to hold off on this PR, until we figure out if we want to merge #51817 or not. If so, we can avoid needing to skip some of these tests.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 802423d into elastic:master Dec 11, 2019
@chrisronline chrisronline deleted the monitoring/cloud_7.5_tests branch December 11, 2019 21:34
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 11, 2019
* Fix cloud test issues

* We don't have to skip for cloud
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 11, 2019
* Fix cloud test issues

* We don't have to skip for cloud
chrisronline added a commit that referenced this pull request Dec 12, 2019
* Fix cloud test issues

* We don't have to skip for cloud
chrisronline added a commit that referenced this pull request Dec 12, 2019
* Fix cloud test issues

* We don't have to skip for cloud
@chrisronline
Copy link
Contributor Author

Backport:

7.x: b4a7df2
7.5: 1a81538

jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 30, 2019
…aved-objects

* upstream/master: (134 commits)
  [Dashboard] Add visualization from dasbhoard empty screen (elastic#52670)
  Print out agent debugging links during CI (elastic#52812)
  Add babel-plugin-styled-components to webpack config (elastic#52862)
  [Console] Fix load from remote (elastic#52814)
  Ensure APM agent config file path respects CWD (elastic#52880)
  [Watcher] Removed overwritten property (elastic#49998)
  [Data Plugin]: Remove `export *` for common code from public/server index files (elastic#52821)
  Hide stderr git output during APM agent configuration (elastic#52878)
  Polish migration.md (elastic#52764)
  Change ajax_stream to use new-line delimited JSON (elastic#52797)
  Stabilize dashboard save modal functional test (elastic#52761)
  [Discover] Place tooltip at bottom of filter button (elastic#52720)
  Disable/enable filter with click+shift on a filter badge (elastic#52751)
  [APM] Make client-side routes static (elastic#52574)
  [Maps] Get basic structure of NP client shim in place (elastic#52551)
  update chromedriver to 79 (elastic#52784)
  [DOCS] Adds example of assigning roles in Reporting (elastic#52757)
  Add instructions for setting up remote clusters needed for CCS and CCR (elastic#52796)
  [docs] max-old-space-size (elastic#52310)
  [Monitoring] Fix 7.5 cloud test issues (elastic#51781)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment